Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): @types/jest should be a dep, not a devDep #672

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

agilgur5
Copy link
Collaborator

  • per bug report, this caused an issue where the @types/jest that was
    installed via create would have a version mismatch with the jest
    and jest-related deps used by TSDX

  • and ts-jest's installation instructions also say to install
    @types/jest, so it's kind of a peerDep to it

  • also move @types/shelljs to devDeps as it's not needed for usage of
    the CLI, it's only used internally


Fixes #633 .
@types/jest was added to the templates in one of the first commits in 9010ecb.
Per the issue, @types/jest was added as a devDep in #146 when the first TS test was added (makes sense) and @types/shelljs was added as a dep in #244

- per bug report, this caused an issue where the @types/jest that was
  installed via `create` would have a version mismatch with the jest
  and jest-related deps used by TSDX
- and ts-jest's installation instructions also say to install
  @types/jest, so it's kind of a peerDep to it

- also move @types/shelljs to devDeps as it's not needed for usage of
  the CLI, it's only used internally
Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pretty straightforward

@agilgur5 agilgur5 merged commit 2930943 into jaredpalmer:master Apr 11, 2020
@agilgur5
Copy link
Collaborator Author

ts-jest recently added @types/jest as a dep: kulshekhar/ts-jest#1859

paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
- per bug report, this caused an issue where the @types/jest that was
  installed via `create` would have a version mismatch with the jest
  and jest-related deps used by TSDX
- and ts-jest's installation instructions also say to install
  @types/jest, so it's kind of a peerDep to it

- also move @types/shelljs to devDeps as it's not needed for usage of
  the CLI, it's only used internally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Why not include @types/jest as TSDX's dependencies?
1 participant